Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sentiment analysis and automerge for dependabot #449

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Add sentiment analysis and automerge for dependabot #449

merged 1 commit into from
Oct 2, 2020

Conversation

HashTalmiz
Copy link
Contributor

@HashTalmiz HashTalmiz commented Oct 1, 2020 •
edited by derberg
Loading

This PR is for: #445

Description
GH Actions PR

  • Added Sentiment Analysis workflow
  • pull_request changed to pull_request_target in .github/workflows/welcome-first-time-contrib.yml file
  • Added Automerge workflow

Resolves: #445
NPM run test works 100%

@HashTalmiz
Added Sentiment Analysis and automerge for dependabot --Github Action…
6b3dc76 
… Workflows

Also made a change to first time contribution workflows
@sonarcloud
Copy link

sonarcloud bot commented Oct 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@HashTalmiz HashTalmiz changed the title Added Sentiment Analysis and automerge for dependabot --Github Action Worflows Added Sentiment Analysis and automerge for dependabot --Github Action Workflows Oct 1, 2020
@HashTalmiz
Copy link
Contributor Author

Seems like #445 is a duplicate to the same issue.

@derberg
Copy link
Member

derberg commented Oct 2, 2020

@HashTalmiz #445 is for this asyncapi repo while asyncapi/.github#9 for .github repo. GitHub Actions unfortunately do not yet support global actions, this is why we need to duplicate many workflows across all repos 😞 thus every repo has its own issue. I will adjust description of this PR so after merge proper issue is closed

@derberg derberg mentioned this pull request Oct 2, 2020
Closed
@derberg derberg changed the title Added Sentiment Analysis and automerge for dependabot --Github Action Workflows Add sentiment analysis and automerge for dependabot Oct 2, 2020
@derberg derberg merged commit 4f93763 into asyncapi:master Oct 2, 2020
@derberg
Copy link
Member

derberg commented Oct 2, 2020

@HashTalmiz great stuff man, merged. I just changed description of PR a bit to make it more ❤️ and follow imperative mode. It is important

@HashTalmiz
Copy link
Contributor Author

They looked very similar hence I misunderstood it as a duplicate 😅

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0-2021-06-release.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

1 similar comment
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
released on @2021-06-release released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup GitHub Actions workflows
3 participants
@HashTalmiz @derberg @asyncapi-bot