Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix release workflow to support release branches #834

Merged
merged 3 commits into from
Sep 20, 2022
Merged

ci: fix release workflow to support release branches #834

merged 3 commits into from
Sep 20, 2022

Conversation

derberg
Copy link
Member

@derberg derberg commented Sep 15, 2022

when we changed release branches, we forgot to update the workflow that reacts to them, we forgot to change the names of branches in the config

I intentionally did not make a change like '**-spec' to have branches named explicitly

@derberg
Copy link
Member Author

derberg commented Sep 15, 2022

@fmvilas @dalelane I need quick approval as we are now not able to produce release candidates for 2.5.0 as we should

@char0n
Copy link
Collaborator

char0n commented Sep 20, 2022

Right, I've just bumped into this issue as well. @fmvilas @dalelane can you approve please?

@derberg would you able to trigger this workflow manually after the change is merged? We need a pre-release for parser-js.

@derberg
Copy link
Member Author

derberg commented Sep 20, 2022

@char0n manual run is not available, and rerun will probably not pick this change. But maybe we will be able to merge googepubsub binding soon, otherwise, we will just have to do an empty PR to trigger release 🤷🏼

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg
Copy link
Member Author

derberg commented Sep 20, 2022

@fmvilas @dalelane one of you folks need to approve this one 🙏🏼

@derberg
Copy link
Member Author

derberg commented Sep 20, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 4c64ab4 into asyncapi:master Sep 20, 2022
@derberg derberg deleted the fixreleaseworkflow branch September 20, 2022 17:24
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-major-spec.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-spec.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member Author

derberg commented Jan 31, 2023

Recent comments about the release from the bot were added by mistake. More details in #899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants