Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix example for operation security #873

Merged
merged 1 commit into from
Nov 17, 2022
Merged

chore: fix example for operation security #873

merged 1 commit into from
Nov 17, 2022

Conversation

derberg
Copy link
Member

@derberg derberg commented Nov 16, 2022

@sonarcloud
Copy link

sonarcloud bot commented Nov 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg derberg mentioned this pull request Nov 16, 2022
Merged
dalelane
dalelane approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derberg
Copy link
Member Author

derberg commented Nov 17, 2022

/rtm

@derberg
Copy link
Member Author

derberg commented Nov 17, 2022

I assume that if we have already one code owner approval and that it is just a small fix, then I do not need to wait for more approvals

@derberg derberg merged commit eb8bb65 into asyncapi:master Nov 17, 2022
@derberg derberg deleted the fixexample branch November 17, 2022 15:31
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@jonaslagoni jonaslagoni mentioned this pull request Dec 4, 2023
Merged
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major-spec.18 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@dalelane dalelane dalelane approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@smoya smoya Awaiting requested review from smoya smoya is a code owner

@char0n char0n Awaiting requested review from char0n char0n is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
released on @next-major-spec released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@derberg @asyncapi-bot @dalelane @magicmatatjahu