Allow the driver to operate in Xpad360 emulation mode #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakra
force-pushed
the
queue/allow-exact-usb-xpad360-emulation
branch
from
f3d9e54
to
e72be85
Compare
kakra
force-pushed
the
queue/allow-exact-usb-xpad360-emulation
branch
3 times, most recently
from
11398b6
to
15c53d2
Compare
24 tasks
kakra
force-pushed
the
queue/allow-exact-usb-xpad360-emulation
branch
from
15c53d2
to
45df9fc
Compare
kakra
force-pushed
the
queue/allow-exact-usb-xpad360-emulation
branch
from
45df9fc
to
f2fda05
Compare
kakra
force-pushed
the
queue/allow-exact-usb-xpad360-emulation
branch
2 times, most recently
from
2dc927c
to
902f3a1
Compare
kakra
force-pushed
the
queue/allow-exact-usb-xpad360-emulation
branch
from
902f3a1
to
0990923
Compare
kakra
force-pushed
the
queue/allow-exact-usb-xpad360-emulation
branch
from
0990923
to
a087b16
Compare
kakra
added a commit
that referenced
this pull request
May 30, 2022
A new SDL gamecontrollerdb entry allows us to get rid of the Xbox button fixup we are carrying around. While this button is still not exactly a button for games, all software expects it to be part of the gamepad mapping anyways. This leaves only the Share button left in the consumer control bits which doesn't have an jsdev equivalent. Affects: #286 Maybe-affects: #283 Fixes: #362 Fixes: #359 Closes: #301 Signed-off-by: Kai Krakow <kai@kaishome.de>
kakra
added a commit
to kakra/xpadneo
that referenced
this pull request
May 30, 2022
A new SDL gamecontrollerdb entry allows us to get rid of the Xbox button fixup we are carrying around. While this button is still not exactly a button for games, all software expects it to be part of the gamepad mapping anyways. This leaves only the Share button left in the consumer control bits which doesn't have an jsdev equivalent. Affects: atar-axis#286 Maybe-affects: atar-axis#283 Fixes: atar-axis#362 Fixes: atar-axis#359 Closes: atar-axis#301 Signed-off-by: Kai Krakow <kai@kaishome.de>
kakra
force-pushed
the
queue/allow-exact-usb-xpad360-emulation
branch
from
a087b16
to
52f4625
Compare
kakra
added a commit
that referenced
this pull request
May 30, 2022
A new SDL gamecontrollerdb entry allows us to get rid of the Xbox button fixup we are carrying around. While this button is still not exactly a button for games, all software expects it to be part of the gamepad mapping anyways. This leaves only the Share button left in the consumer control bits which doesn't have an jsdev equivalent. Affects: #286 Maybe-affects: #283 Fixes: #362 Fixes: #359 Closes: #301 Signed-off-by: Kai Krakow <kai@kaishome.de>
kakra
force-pushed
the
queue/allow-exact-usb-xpad360-emulation
branch
from
52f4625
to
ed5cf29
Compare
kakra
added a commit
to kakra/xpadneo
that referenced
this pull request
Sep 15, 2022
Switching to PID 0x028E seems to successfully evade the mappings in Proton, and thus probably SDL. Proton seems to do the same for Steam virtual controllers, and it seems to also fix gamepad handling in Chrome. Maybe-fixes: atar-axis#379 Maybe-affects: atar-axis#385 Maybe-affects: ValveSoftware/steam-for-linux#8463 (comment) See-also: atar-axis#283 See-also: ValveSoftware/wine@7ea1cc2 Fixes: atar-axis#373 Signed-off-by: Kai Krakow <kai@kaishome.de>
kakra
added a commit
to kakra/xpadneo
that referenced
this pull request
Sep 15, 2022
Switching to PID 0x028E seems to successfully evade the mappings in Proton, and thus probably SDL. Proton seems to do the same for Steam virtual controllers, and it seems to also fix gamepad handling in Chrome. Maybe-fixes: atar-axis#379 Maybe-affects: atar-axis#385 Maybe-affects: ValveSoftware/steam-for-linux#8463 (comment) See-also: atar-axis#283 See-also: ValveSoftware/wine@7ea1cc2 Fixes: atar-axis#373 Signed-off-by: Kai Krakow <kai@kaishome.de>
This mode disables most advanced features and exposes the device as an original USB-connected Xbox 360 controller. Use module parameter `xpad_emulation=1`. This may be useful for applications like Retroarch or other programs that need the Guide button exposed as a joystick button. Essentially, it enables such applications to use the button as a macro modifier button, and the button will no longer be sent as a consumer control key (but still announced as being available). In this mode, joydev inserts the button before the left and right thumb buttons which may mess up some mappings, especially with joydev. Since we are pretending to be a USB Xbox360 controller, most programs will take care of it. For hidraw programs, we also scale the trigger range down from 0..1023 to 0..255 which makes the trigger slightly less precise. This parameter cannot be changed at runtime, you must reload the module with the parameter changed to apply the emulation correctly. Fixes: atar-axis#237 Affects: atar-axis#273 Fixes: atar-axis#280 Signed-off-by: Kai Krakow <kai@kaishome.de>
kakra
force-pushed
the
queue/allow-exact-usb-xpad360-emulation
branch
from
ed5cf29
to
257f24b
Compare
|
Code Climate has analyzed commit 257f24b and detected 0 issues on this pull request. View more on Code Climate. |
kakra
added a commit
that referenced
this pull request
Sep 17, 2022
Switching to PID 0x028E seems to successfully evade the mappings in Proton, and thus probably SDL. Proton seems to do the same for Steam virtual controllers, and it seems to also fix gamepad handling in Chrome. Maybe-fixes: #379 Maybe-affects: #385 Maybe-affects: ValveSoftware/steam-for-linux#8463 (comment) See-also: #283 See-also: ValveSoftware/wine@7ea1cc2 Fixes: #373 Signed-off-by: Kai Krakow <kai@kaishome.de>
41 tasks
|
xpadneo now has options in place that should work around any left issues with this. The only thing left is using 8-bit values for the triggers, this should be fixed in user-space. Future customization option may add additional improvements. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo: