Add new PublishAsync to send multiple messages in batches #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomMalow
force-pushed
the
feature/service-bus-publish-batch
branch
from
270af07 to
3d0a46b
Compare
|
@TomMalow the build fails due to incorrect XML code documentation |
TomMalow
force-pushed
the
feature/service-bus-publish-batch
branch
from
3d0a46b to
53492e3
Compare
…tches The new method will publish multiple messages in a batch. If the messages exceed the batch size, the current batch will be sent and remaining will be send in a new batch. Multiple batches can be sent The method will throw an exception if a single message exceeds the total allowed size of a single batch. Does not rollback any previous sent messages.
TomMalow
force-pushed
the
feature/service-bus-publish-batch
branch
from
53492e3 to
b003eea
Compare
|
|
||
| var busMessage = CreateServiceBusMessage( | ||
| sessionId, | ||
| JsonSerializer.Serialize(message), |
There was a problem hiding this comment.
I think this pull request should go in but I also noticed that we are very opinionated about how the messages are serialized
There was a problem hiding this comment.
I agree and have intention to separate this in a later PR
There was a problem hiding this comment.
This was also the main reason why I could not use this package initially as I have customer converters
|
Do you feel like adding usage examples in the README @TomMalow? Otherwise, I can do that in a separate pull request |
|
Kudos, SonarCloud Quality Gate passed! |
TomMalow
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new method will publish multiple messages in a batch. If the messages exceed the batch size, the current batch will be sent and remaining will be send in a new batch. Multiple batches can be sent
The method will throw an exception if a single message exceeds the total allowed size of a single batch. Does not rollback any previous sent messages.