Energy loss relative tolerance #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
get_timelag_fromU0for lattice with very large U0 and multiple RF harmonics.The reason is that for multiple harmonic a least square fit is use to compute the synchronous phase, the quantity to minimize is the difference between U0 and the accelerating voltage.
However using the absolute difference, the tolerance was becoming too tight for very large U0. This value is now normalized to U0. In addition, the tolerance was reduced to 1.0e-9 and set as an optional argument.
A small modification to envelope_parameters() is also propose to prevent attribute errors when voltage<U0. The function now simply returns a NaN.