Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable inaccurate Ameba rule #344

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Disable inaccurate Ameba rule #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .ameba.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ Lint/ComparisonToBoolean:
Enabled: false # TODO: Enable once https://github.com/crystal-ameba/ameba/issues/432 is resolved
Lint/NotNil:
Enabled: false
Lint/UselessAssign:
Enabled: false # TODO: Enable once https://github.com/crystal-ameba/ameba/issues/447 is resolved
Naming/AccessorMethodName:
Enabled: false
Naming/BlockParameterName:
Expand Down
2 changes: 0 additions & 2 deletions src/components/framework/spec/controller_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ require "./spec_helper"
describe ATH::Controller do
describe ".render" do
it "creates a proper response for the template" do
# ameba:disable Lint/UselessAssign
name = "TEST"
response = ATH::Controller.render "#{__DIR__}/assets/greeting.ecr"

Expand All @@ -13,7 +12,6 @@ describe ATH::Controller do
end

it "creates a proper response for the template with a layout" do
# ameba:disable Lint/UselessAssign
name = "TEST"
response = ATH::Controller.render "#{__DIR__}/assets/greeting.ecr", "#{__DIR__}/assets/layout.ecr"

Expand Down