Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder method to configure custom ResourceResolver #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

logogin
Copy link

@logogin logogin commented Dec 20, 2017

This small change adds ability to set custom ResourceResolver via Builder. Custom resolver will allow loading dictionaries from locations other than Java classpath.

@logogin
Copy link
Author

logogin commented Jan 23, 2018

Any chance to get this merged?

@cmoen
Copy link
Member

cmoen commented Jan 30, 2018

Could you elaborate a bit on the use-case of when you'd load custom dictionaries from locations other than the Java classpath? Just trying to understand the underlying use-case. Thanks.

@logogin
Copy link
Author

logogin commented Jan 31, 2018

Thanks for the response!
The are couple of use-cases:

  1. You need to update/recompile dictionaries without code change. In this case dictionaries may be stored separately from the library.
  2. Dictionary/model files may have licence different from one used for the source code. There could be internal policies which may prohibit to deploy software with mixed or special types of licences.
  3. You have a special central model storage, i.e. S3 where all models maintained.

It is also, in general, a very trivial change which is backwards-compatible and does not affect library API. The ResourceResolver interface is already there, it is just hardcoded to resolve always from classpath.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants