Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize coding style #157

Merged
merged 3 commits into from
Apr 14, 2020
Merged

Modernize coding style #157

merged 3 commits into from
Apr 14, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Apr 13, 2020 •
edited by romaninsh
Loading

Implement PSR12

@mvorisek
Copy link
Member Author

@romaninsh , @abbadon1334 Can we configure StyleCI to use CS from .php_cs.dist directly?

@abbadon1334
Copy link
Collaborator

@romaninsh , @abbadon1334 Can we configure StyleCI to use CS from .php_cs.dist directly?

No it has is own configuration file, we need to find a sync between StyleCI and PHPCS and set all repos to that.

@romaninsh romaninsh marked this pull request as ready for review April 14, 2020 08:27
@romaninsh romaninsh merged commit 1dbe39a into develop Apr 14, 2020
@romaninsh romaninsh deleted the mvorisek-patch-cs-improve branch April 14, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romaninsh romaninsh romaninsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvorisek @abbadon1334 @romaninsh