Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore type for phpunit 5.x compatibility #171

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Ignore type for phpunit 5.x compatibility #171

merged 1 commit into from
Apr 23, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Apr 22, 2020 •
edited
Loading

@codecov
Copy link

codecov bot commented Apr 22, 2020 •
edited
Loading

Codecov Report

Merging #171 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #171   +/-   ##
==========================================
  Coverage      97.03%   97.03%           
  Complexity       448      448           
==========================================
  Files             24       24           
  Lines           1046     1046           
==========================================
  Hits            1015     1015           
  Misses            31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48cee66...9c825f9. Read the comment docs.

georgehristov
georgehristov approved these changes Apr 23, 2020
View reviewed changes
Copy link
Collaborator

@georgehristov georgehristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvorisek mvorisek merged commit f0520e5 into develop Apr 23, 2020
@mvorisek mvorisek deleted the fix_phpunit5 branch April 23, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehristov georgehristov georgehristov approved these changes

@DarkSide666 DarkSide666 Awaiting requested review from DarkSide666

@abbadon1334 abbadon1334 Awaiting requested review from abbadon1334

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @georgehristov