Append missing slash to locale directory #174
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #174 +/- ##
==========================================
Coverage 97.03% 97.03%
Complexity 448 448
==========================================
Files 24 24
Lines 1046 1046
==========================================
Hits 1015 1015
Misses 31 31
Continue to review full report at Codecov.
|
| @@ -95,7 +95,7 @@ protected function loadDefinitionATK(string $locale): void | |||
|
|
|||
| if (class_exists('\atk4\data\Locale')) { | |||
| $path = Locale::getPath(); | |||
| $this->addDefinitionFromFile($path . $locale . '/atk.php', $locale, 'atk', 'php-inline'); | |||
| $this->addDefinitionFromFile($path . '/' . $locale . '/atk.php', $locale, 'atk', 'php-inline'); | |||
There was a problem hiding this comment.
I suggest replacing / with DIRECTORY_SEPARATOR here
There was a problem hiding this comment.
I already fixed your feedback for this in atk4/ui#1124 , but it should be not needed and as you can see here - a few chars later :) there is /. So LGTM?
PS: / does work on WIndows perfectly, if there are any issues is general, let me know
There was a problem hiding this comment.
We can make it better than it was (replacing the existing /) :)
It is just to keep it being OS agnostic as far as possible
There was a problem hiding this comment.
It is up too you to fix this, I will not propose these changes.
No description provided.