Sort numerical keys in mergeSeeds #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #182 +/- ##
=============================================
+ Coverage 96.94% 96.97% +0.02%
- Complexity 443 444 +1
=============================================
Files 24 24
Lines 1047 1057 +10
=============================================
+ Hits 1015 1025 +10
Misses 32 32
Continue to review full report at Codecov.
|
DarkSide666
requested changes
Apr 28, 2020
There was a problem hiding this comment.
Complex and I don't see reason for that.
I think I fixed it here https://github.com/atk4/core/pull/182/files#diff-0465835788d64e7f6e72e370ba840cfaR156.
Maybe here we should simply have ksort($arguments, SORT_NUMERIC) before this array_shift line ?
DarkSide666
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.