Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip trace from nested exception constructors #188

Merged
merged 1 commit into from
May 2, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Apr 30, 2020

Resulting trace is equal as copying this code from the base Exception class:

$this->trace2 = debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT);

to the extended Exception classes.

With this PR, the trace is reduced properly without any need for code duplication.

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #188 into develop will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #188      +/-   ##
=============================================
+ Coverage      96.97%   96.99%   +0.02%     
- Complexity       444      451       +7     
=============================================
  Files             24       24              
  Lines           1057     1065       +8     
=============================================
+ Hits            1025     1033       +8     
  Misses            32       32              
Impacted Files Coverage Δ Complexity Δ
src/Exception.php 100.00% <100.00%> (ø) 24.00 <0.00> (+7.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 503ed2f...2e7c9a8. Read the comment docs.

@mvorisek mvorisek marked this pull request as ready for review April 30, 2020 12:53
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine with me.

@DarkSide666 DarkSide666 merged commit a3a6d8a into develop May 2, 2020
@DarkSide666 DarkSide666 deleted the better_exception_trace branch May 2, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants