Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callable should be supported only for dynamic default value #195

Merged
merged 1 commit into from
May 15, 2020
Merged

Callable should be supported only for dynamic default value #195

merged 1 commit into from
May 15, 2020

Conversation

mvorisek
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #195 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #195   +/-   ##
==========================================
  Coverage      97.10%   97.10%           
  Complexity       452      452           
==========================================
  Files             24       24           
  Lines           1070     1070           
==========================================
  Hits            1039     1039           
  Misses            31       31
Impacted Files Coverage Δ Complexity Δ
src/SessionTrait.php 97.43% <100.00%> (ø) 17.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2fe68b...ffd0185. Read the comment docs.

@mvorisek mvorisek mentioned this pull request May 14, 2020
Merged
@mvorisek mvorisek marked this pull request as ready for review May 14, 2020 20:34
DarkSide666
DarkSide666 approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good, thank you!

@DarkSide666 DarkSide666 merged commit b050e9f into develop May 15, 2020
@DarkSide666 DarkSide666 deleted the do_not_use_closure_when_not_needed branch May 15, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

@romaninsh romaninsh Awaiting requested review from romaninsh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @DarkSide666