Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore also the 1st call of exception constructor in trace #208

Merged
merged 1 commit into from
May 19, 2020

Conversation

mvorisek
Copy link
Member

fix #200

@codecov
Copy link

codecov bot commented May 17, 2020

Codecov Report

Merging #208 into develop will decrease coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #208      +/-   ##
=============================================
- Coverage      97.09%   96.70%   -0.39%     
+ Complexity       450      447       -3     
=============================================
  Files             24       24              
  Lines           1066     1063       -3     
=============================================
- Hits            1035     1028       -7     
- Misses            31       35       +4     
Impacted Files Coverage Δ Complexity Δ
src/Exception.php 100.00% <100.00%> (ø) 21.00 <0.00> (-3.00)
src/ExceptionRenderer/Console.php 98.41% <0.00%> (-1.59%) 24.00% <0.00%> (ø%)
src/ExceptionRenderer/HTMLText.php 98.48% <0.00%> (-1.52%) 24.00% <0.00%> (ø%)
src/ExceptionRenderer/RendererAbstract.php 98.52% <0.00%> (-1.48%) 30.00% <0.00%> (ø%)
src/ExceptionRenderer/HTML.php 98.64% <0.00%> (-1.36%) 26.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f854b0b...f33f182. Read the comment docs.

Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks!

@romaninsh romaninsh merged commit e8c4476 into develop May 19, 2020
@romaninsh romaninsh deleted the do_not_log_ex_constructor branch May 19, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception constructor trace should be never stored at all
2 participants