Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trait identification property #227

Merged
merged 5 commits into from
Apr 6, 2021
Merged

Remove trait identification property #227

merged 5 commits into from
Apr 6, 2021

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Jun 6, 2020 •
edited
Loading

finish after: #221

then remove dummy properties like:
image

and refactor in other repos

Trait identification properties declared in core:

_appScopeTrait|_configTrait|_containerTrait|_debugTrait|_DIContainerTrait|_dynamicMethodTrait|_factoryTrait|_hookTrait|_initializerTrait|_nameTrait|_quickExceptionTrait|_sessionTrait|_staticAddToTrait|_trackableTrait|_translatableTrait

-> they are used solely in core repo except 3 usages in ui repo

@mvorisek mvorisek self-assigned this Jun 6, 2020
@mvorisek mvorisek force-pushed the add_core_hastrait branch 5 times, most recently from c073b69 to decbf70 Compare June 12, 2020 21:15
@mvorisek mvorisek changed the title Add Core::hasTrait() Add proper interfaces for traits Jun 12, 2020
This was referenced Jun 12, 2020
Merged
Closed
@atk4 atk4 deleted a comment from codecov bot Jun 13, 2020
@mvorisek mvorisek mentioned this pull request Jun 19, 2020
Closed
4 tasks
@mvorisek mvorisek force-pushed the add_core_hastrait branch 2 times, most recently from d75b187 to 52b1e13 Compare July 8, 2020 09:04
georgehristov
georgehristov reviewed Mar 19, 2021
View reviewed changes
Copy link
Collaborator

@georgehristov georgehristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I would just use "Interface" instead of "I" only

@mvorisek
Copy link
Member Author

Great, I would just use "Interface" instead of "I" only

Interface suffix?

@georgehristov
Copy link
Collaborator

Yes, basically follow Symfony naming convention

@mvorisek mvorisek force-pushed the add_core_hastrait branch 3 times, most recently from 06b9313 to 06580c1 Compare April 5, 2021 11:18
@mvorisek mvorisek force-pushed the add_core_hastrait branch 3 times, most recently from 98365eb to 3371b96 Compare April 5, 2021 11:27
@mvorisek mvorisek force-pushed the add_core_hastrait branch 3 times, most recently from 865196b to af3ef21 Compare April 5, 2021 12:00
@mvorisek mvorisek changed the title Add proper interfaces for traits Remove trait identification property Apr 5, 2021
@mvorisek mvorisek mentioned this pull request Apr 5, 2021
Closed
@mvorisek mvorisek marked this pull request as ready for review April 5, 2021 13:03
@mvorisek mvorisek requested a review from ibelar April 5, 2021 13:25
@mvorisek mvorisek removed their assignment Apr 5, 2021
@mvorisek mvorisek added the RTM label Apr 5, 2021
@mvorisek mvorisek merged commit 719db90 into develop Apr 6, 2021
@mvorisek mvorisek deleted the add_core_hastrait branch April 6, 2021 13:57
This was referenced Apr 6, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

@georgehristov georgehristov Awaiting requested review from georgehristov

@ibelar ibelar Awaiting requested review from ibelar

Assignees
No one assigned
Labels
BC-break RTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvorisek @georgehristov @DarkSide666