-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix composer develop install issues #231
Conversation
d5c7b3b
to
44284c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- in current develop branch composer updates fine
- in develop branch with version:dev-develop composer updates fine
- in another branch without version:dev-develop composer DO NOT UPDATE - atk4/data dev-develop requires atk4/core dev-develop
- in another branch with version:dev-develop composer updates fine
So it looks that adding version:dev-develop solves this issue.
If we can replace, then something like this should work already:
|
TODO - need to add another |
I think we can also remove here is how to get a version: https://github.com/atk4/ui/blob/09ae0f67deda221ba2f48d6d3beb00be01e7a010/.github/workflows/bundler.yml#L41 |
6a55ddb
to
c52f953
Compare
c52f953
to
5dac7e3
Compare
@romaninsh @DarkSide666 updated post about deps, wdyt? Very robust if we can let the release script do the work... |
having |
fixes #193
these two lines should stay on release (they are for root composer project only, they may still be required for dev deps):
but this one:
should be remove completely on release.
For all repos.