Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix composer develop install issues #231

Merged
merged 3 commits into from
Jul 14, 2020
Merged

Fix composer develop install issues #231

merged 3 commits into from
Jul 14, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Jun 7, 2020

fixes #193

these two lines should stay on release (they are for root composer project only, they may still be required for dev deps):

  "minimum-stability": "dev",
  "prefer-stable": true,

but this one:

  "version": "dev-develop",

should be remove completely on release.

For all repos.

@mvorisek mvorisek requested a review from DarkSide666 June 7, 2020 14:44
@mvorisek mvorisek changed the title Fix composer install issues Fix composer develop install issues Jun 7, 2020
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • in current develop branch composer updates fine
  • in develop branch with version:dev-develop composer updates fine
  • in another branch without version:dev-develop composer DO NOT UPDATE - atk4/data dev-develop requires atk4/core dev-develop
  • in another branch with version:dev-develop composer updates fine

So it looks that adding version:dev-develop solves this issue.

@DarkSide666 DarkSide666 marked this pull request as ready for review June 14, 2020 10:23
@DarkSide666
Copy link
Member

DarkSide666 commented Jun 14, 2020

If we can replace, then something like this should work already:

// these will be used in develop
"version": "dev-develop",
"minimum-stability": "dev",
"prefer-stable": true,

// these will be used when releasing
"version-release": "something",
"minimum-stability-release": "something",
"prefer-stable-release": true,

@DarkSide666
Copy link
Member

TODO - need to add another jq line in core/.github/workflows/bundler.yml to completely remove version key from json while releasing.

@DarkSide666 DarkSide666 marked this pull request as draft June 14, 2020 10:38
@mvorisek
Copy link
Member Author

mvorisek commented Jul 1, 2020

composer config version --unset seems to be much cleaner approach

I think we can also remove require(-dev)?-release completely and in release process replace all (?<=atk4/xxx: )dev-* requires with ^version

here is how to get a version: https://github.com/atk4/ui/blob/09ae0f67deda221ba2f48d6d3beb00be01e7a010/.github/workflows/bundler.yml#L41

@mvorisek
Copy link
Member Author

mvorisek commented Jul 8, 2020

@romaninsh @DarkSide666 updated post about deps, wdyt? Very robust if we can let the release script do the work...

@mvorisek mvorisek requested a review from romaninsh July 8, 2020 23:38
@DarkSide666
Copy link
Member

having ...-release is still ok for now, so let's not complicate this at this point.

@DarkSide666 DarkSide666 marked this pull request as ready for review July 14, 2020 10:52
@DarkSide666 DarkSide666 merged commit 2022083 into develop Jul 14, 2020
@DarkSide666 DarkSide666 deleted the fix_composer_dev branch July 14, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Every dev branch of atk4 repos should replace the 2.x version
2 participants