Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use is_int for numeric array keys detection #267

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Use is_int for numeric array keys detection #267

merged 1 commit into from
Aug 21, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Aug 21, 2020 •
edited
Loading

numeric key <=> integer key in php

@mvorisek mvorisek added the RTM label Aug 21, 2020
georgehristov
georgehristov approved these changes Aug 21, 2020
View reviewed changes
Copy link
Collaborator

@georgehristov georgehristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvorisek mvorisek merged commit 7665feb into develop Aug 21, 2020
@mvorisek mvorisek deleted the better_numeric_key_detection branch August 21, 2020 12:56
@PhilippGrashoff
Copy link

nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehristov georgehristov georgehristov approved these changes

@DarkSide666 DarkSide666 Awaiting requested review from DarkSide666

Assignees
No one assigned
Labels
RTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvorisek @PhilippGrashoff @georgehristov