Display Exception in Atk callback

[mvorisek]

Currently, when callback is used and an Exception occurs, simple message:

!! Callback requested, but never reached. You may be missing some arguments in...

is displayed.

Currently it is very hard to understand what is going wrong.

At least the Exception message should be displayed in the error (located in

ui/src/App.php

Line 415 in 695baeb

$this->terminate('!! Callback requested, but never reached. You may be missing some arguments in '.$_SERVER['REQUEST_URI']);

).

And also HTTP code = 500 should be returned.

[funyx]

if (isset($_GET['__atk_callback']) && $this->catch_runaway_callbacks) {
            $this->terminate('!! Callback requested, but never reached. You may be missing some arguments in '.$_SERVER['REQUEST_URI']);
        }

that is the flag in the check:

 /**
     * Will display error if callback wasn't triggered.
     *
     * @var bool
     */
    public $catch_runaway_callbacks = true;

[mvorisek]

Yes, when an exception is throw inside the callback, the catch_runaway_callbacks property is not cleared. So it should be cleared before the callback is processed and the result should be the exception message / handler result.

But an HTTP code = 500 should be set in general before any error output, ie. here too.

[funyx]

I guess that flag only checks if the function is reachable/exists..
So if you want an exception you should implement it like this..

$this->addHook('beforeOutput,',function(){
  throw new \HookBreaker(new Exception('wops',1234));
});

try {
new App();
} catch ( \HookBreaker $e) {
// maybe switch $e->getCode()..
throw $e;
}

[mvorisek]

Already fixed in the last version on this line:

ui/src/App.php

Line 251 in 695baeb

$l->catch_runaway_callbacks = false;