Enable check and test for all branches

[congwang09]

Enable check and test for all branches and all commits.

[coveralls]

Pull Request Test Coverage Report for Build 9500799262

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 52.322%

---

Totals
Change from base Build 9500593558:	0.0%
Covered Lines:	748
Relevant Lines:	1456

---

💛 - Coveralls

[sajith]

Unless I misunderstood something, these changes do not do anything new. Tests are already run against a PR branch on every push. That is what pull_request: means; we do not need a branches: under that.

[congwang09]

Before this change, github actions only run code checks and tests after the PR is created. This change lets us see failed tests before the PR is created.

After the change the checks run on every commit:

[sajith]

Ah, so you want to run tests against every commit. The trouble with that is, we only get a limited amount of free CI time (3000 minutes per month, across all repositories in the organization) on GitHub's infrastructure. We will quickly run out of that resource if we run tests against every commit.

It is good enough that main branch passes tests, and code that we merge into the main branch passes tests.

[congwang09]

Ah, so you want to run tests against every commit. The trouble with that is, we only get a limited number of free CI time (3000 minutes per month) on GitHub's infrastructure. We will quickly run out of that resource if we run tests against every commit.

It is good enough that main branch passes tests, and code that we merge into the main branch passes tests.

Oh I see. that makes sense. I'll close this PR.