Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hint-mode #3345

Merged
merged 8 commits into from
Mar 1, 2024
Merged

Fix hint-mode #3345

merged 8 commits into from
Mar 1, 2024

Conversation

aadcg
Copy link
Member

@aadcg aadcg commented Feb 20, 2024 •
edited
Loading

Description

Fixes #3285
Fixes #3339

Ensure that the fix doesn't re-introduce #3261.

Checklist:

  • Git branch state is mergable.
  • Changelog is up to date (via a separate commit).
  • New dependencies are accounted for.
  • Documentation is up to date.
  • Compilation and tests ((asdf:test-system :nyxt/gi-gtk))
    • No new compilation warnings.
    • Tests are sufficient.

@aadcg aadcg marked this pull request as ready for review February 27, 2024 13:56
@jmercouris jmercouris self-assigned this Feb 27, 2024
@jmercouris
Copy link
Member

I have tested it, and I don't believe it works on the URL https://developer.servicenow.com/dev.do as linked in #3001. In other words it doesn't work ON the Shadow DOM. The same behavior is exhibited in 3.11.3. I don't know if that website https://developer.servicenow.com/dev.do has changed since the original issue was posted, but more or less none of the links work.

I confirm that the fix works for zoomed in pages.
I confirm that it adds things to the shadow DOM to avoid polluting the main DOM.

jmercouris
jmercouris approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@jmercouris jmercouris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot that we dropped support for the shadow DOM temporarily. In light of this, everything is OK!

@aadcg
Copy link
Member Author

aadcg commented Mar 1, 2024

There are issues when using the :vi hinting-type. I'll fix those.

@aadcg
mode/hint: Fix bug related to dim-hint-prefix.
1e468b7 
Oddly enough, it prevented dim-hint-prefix to work properly.  The position needs
to be set inline, such that children of span elements of class nyxt-hint (see
span elements created by dim-hint-prefix) inherit the property.

Introduced in commit b571aef.
@aadcg
mode/hint: Fix bug on zoomed pages.
7458ec0 
On zoomed pages, nyxt/ps:element-overlapped-p replies that all elements are
overlapped.  When using the default zoom, it does perform as intended.

When the feature was introduced, in commit
2575c08, it already suffered from the issue
mentioned above.
@aadcg
mode/hint(dim-hint-prefix): Conserve font-size.
d94f9bd
@aadcg
tests/renderer-offline/hint-mode-html-document: Add note.
8ba8ce6
@aadcg
changelog: Mention hint mode bug fix.
6229c2a
@aadcg aadcg merged commit 177d4ce into master Mar 1, 2024
1 check failed
@aadcg aadcg deleted the fix-3339-and-3285 branch March 1, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmercouris jmercouris jmercouris approved these changes

Assignees

@jmercouris jmercouris

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misplaced hints in zoomed pages hint-mode encapsulate hints via Shadow DOM
2 participants
@aadcg @jmercouris