macOS Electron tmp fixes #3414
Merged
macOS Electron tmp fixes #3414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both on Electron+macOS and Electron+Linux custom fonts aren't working. On Electron+Linux, no errors are raised, whereas on Electron+macOS the opposite is observed. It's odd, but we'll fix custom fonts on the Electron port anyway on both settings in the future. The changes have no impact on the webkitGTK port.
These work on Electron+Linux. It is an open question why they fail on Electron+macOS. Note that the glyph-logo (Nyxt logo) actually works on the startup buffer (nyxt:new) on Electron+macOS. Odd.
It messes up the geometry of the layout and it may not be trivial to fix it. I didn't find a way to determine the height of the topbar (the iconic macOS semaphore buttons).
Although it works on Electron+Linux, it fails on Electron+macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As to ease development, since these issues are minor compares to the remaining ones.
Checklist:
(asdf:test-system :nyxt/<renderer>))