Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more IDE cases to gitignore #24

Merged
merged 1 commit into from
May 3, 2016
Merged

add more IDE cases to gitignore #24

merged 1 commit into from
May 3, 2016

Conversation

yespire
Copy link
Contributor

@yespire yespire commented Apr 28, 2016

No description provided.

@pmjones
Copy link
Contributor

pmjones commented May 3, 2016

Thanks for these. I should try to make them standard across all my packages.

@pmjones pmjones merged commit 715a3d0 into atlasphp:0.x May 3, 2016
@jakejohns
Copy link
Contributor

@pmjones if you wish to include robust gitignore for all the packages, I might suggest the boilerplates:
https://github.com/github/gitignore

They're a little more robust than what's here, for example, vim, my editor of choice:
https://github.com/github/gitignore/blob/master/Global/Vim.gitignore

There's also a nice little utility I tend to use to ease the burden of this:
https://github.com/simonwhitaker/gibo

@opengeek
Copy link

opengeek commented May 3, 2016

Just throwing this out there...

I've read recently that the prevailing trend was not to have exclusions per project, but rather for users to exclude their IDE and other development platform dependent exclusions in their global gitignore instead? Perhaps this is not widely accepted yet? The idea of keeping the project clean and putting the burden on the developer-specific environment is certainly logical, but I'd like to hear more opinions.

@pmjones
Copy link
Contributor

pmjones commented May 3, 2016

@opengeek Good grief, I didn't even know there was a global .gitignore.

@jakejohns
Copy link
Contributor

honestly, what @opengeek sez seems right to me.

@yespire
Copy link
Contributor Author

yespire commented May 4, 2016

Thank you for the information, I was not aware of the global gitignore for IDE cases either, hence the pull request. I do agree with the approach of using global gitignore to manage multiple projects.

However, I think for an open source package, we may save some hassle by having common IDE files covered, the rationale:

  1. that some developers might not have proper global gitignore configured, hence the chance of introducing a file like .DS_Store, .idea in their commits
  2. some extra .gitignore won't hurt even if there is overlapping global gitignore

@pmjones
Copy link
Contributor

pmjones commented May 4, 2016

that some developers might not have proper global gitignore configured

I think in that case, it has become our burden to educate them.

some extra .gitignore won't hurt even if there is overlapping global gitignore

True, though not-having the overlap wouldn't hurt either.

I think the right thing to do here is encourage a global .gitignore for each developer, and limit package-specific ignores to package-specific concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants