Adds two optimisations, Upgrades to collector v1.32.0/v0.126.0 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two tail sampling optimisations. Both related to easing pressure on the hot path goroutine to help response times. Essentially, moving things out of the bottlenecked path and into other goroutines wherever possible. This is possible in places which do not access state (caches) since they do not need to be synchronized.
jamesmoessis
requested review from
jsonlsy,
san-san,
jordan-simonovski and
jordanbertasso
jsonlsy
approved these changes
May 27, 2025
jcmackie
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades to collector v1.32.0/v0.126.0
Adds two tail sampling optimisations. Both related to easing pressure on the hot path goroutine to help response times. Essentially, moving things out of the bottlenecked path and into other goroutines wherever possible. This is possible in places which do not access state (caches) since they do not need to be synchronized.