#174797464 Reset Password #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adadie
force-pushed
the
ft-reset-password-#174797464
branch
5 times, most recently
from
d7979f3 to
a1bb691
Compare
Adadie
force-pushed
the
ft-reset-password-#174797464
branch
6 times, most recently
from
12ed876 to
8dd6931
Compare
Adadie
requested review from
Habinezajanvier,
b0nbon1,
BeyFaith,
valens10,
dushimeemma,
ericus123,
florisng,
elvisiraguha,
kipropbrian and
jpirumvaa
Adadie
force-pushed
the
ft-reset-password-#174797464
branch
5 times, most recently
from
185d114 to
ed5f57e
Compare
Adadie
force-pushed
the
ft-reset-password-#174797464
branch
from
66938dd to
0c5a5be
Compare
Adadie
force-pushed
the
ft-reset-password-#174797464
branch
4 times, most recently
from
e5f87f4 to
bcc9cb0
Compare
dushimeemma
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
Good job bro, but you have to work on css so that you can leave some space between main area and the footer and also on the form to enter new password you can work on it so that when the eye to view password is clicked can be checked else display as it is. also remove .env from remote.
Adadie
force-pushed
the
ft-reset-password-#174797464
branch
from
bcc9cb0 to
b59a7b3
Compare
Thank you @dushimeemma , though what do you mean by leaving space between main area!!? |
Adadie
force-pushed
the
ft-reset-password-#174797464
branch
2 times, most recently
from
18a749b to
8f11d9f
Compare
Habinezajanvier
requested changes
Dec 17, 2020
elvisiraguha
approved these changes
Dec 17, 2020
Adadie
force-pushed
the
ft-reset-password-#174797464
branch
6 times, most recently
from
21c81c4 to
26fc287
Compare
- create forgot password UI - add an action for forgot password - add a reducer for forgot password [Delivers #174797464]
Adadie
force-pushed
the
ft-reset-password-#174797464
branch
from
26fc287 to
2fc5298
Compare
Habinezajanvier
approved these changes
Dec 18, 2020
valens10
approved these changes
Dec 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements the whole process for resetting the password.
Description of Task to be completed?
How should this be manually tested?
https://github.com/atlp-rwanda/script-heroes-frontend.git.ft-reset-password-#174797464.yarn.yarn start./forgot.What are the relevant pivotal tracker stories?
#174797464
Screenshots (if appropriate)