Remove vmr divmul #378
Merged
Remove vmr divmul #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrayOfSpeciesTagVMR This means that derivatives should now work for 0-VMR The problem was that there used to be an adaptation in adapt_stepwise_partial_derivatives so that these derivatives were rescaled by VMR. This means that they had used to have to be output of the propagation matrix agenda first multiplied by the VMR, so that the adaptation's divide by VMR would not mess up the values. This behavior was kept to keep the behavior to pre-analytical Jacobian calculations identical to how they were back then. Since we want to use the propagation matrix agenda to compute the lookup table, it is now desired that the 0-VMR test case works. This means that the old behavior can no longer be kept.
The Jacobian::Special::ArrayOfSpeciesTagVMR are now computed inside the line shape compute function. So the duplication of code to take it into account has been removed. Also applied relevant clang-tidy comments in the files I had to open to get this code updated
|
@erikssonpatrick This makes the VMR jacobian compatible with 0 VMR which we need for the lookup table. You're okay with this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behavior of the propagation matrix agenda in two ways.
The Jacobian::Special::ArrayOfSpeciesTagVMR derivatives are now output in units of VMR instead of as full absorption coefficients.
There is physical output of the derivative even with 0-VMR input.
This is in preparation for removing the cross-section agenda and adapting the lookup table calculations for use of the propagation matrix agenda.