Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GIS Coordinate Transform to use GeometryInterface #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update GIS Coordinate Transform to use GeometryInterface #14

wants to merge 1 commit into from

Conversation

roboguy
Copy link
Contributor

@roboguy roboguy commented Jun 6, 2017 •
edited
Loading

Replace deprecated method calls in Meta
Move class fields to Data
Use ValueMetaFactory where possible

@cvagner / @darbonc - Please review

@roboguy
Update GIS Coordinate Transform to use GeometryInterface
9f7cbc6 
Replace deprecated method calls in Meta
Move class fields to Data

 Changes to be committed:
	modified:   pentaho-gis-plugins/src/main/java/com/atolcd/pentaho/di/trans/steps/giscoordinatetransformation/GisCoordinateTransformation.java
	modified:   pentaho-gis-plugins/src/main/java/com/atolcd/pentaho/di/trans/steps/giscoordinatetransformation/GisCoordinateTransformationData.java
	modified:   pentaho-gis-plugins/src/main/java/com/atolcd/pentaho/di/trans/steps/giscoordinatetransformation/GisCoordinateTransformationMeta.java
@yazaiez
Copy link

yazaiez commented Jul 20, 2017

hello,
we noticed since the last upgrade that our plugin dont turn well.. Actually we can't see the type Geometry. We tried to undo the commit and it works again. so we think that the use of interface GeometryInterface is causing problem.. If you have an idea or a solution for this issue that would be great : #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roboguy @yazaiez