Start language server with "python -m pyls" #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now require pyls 0.19
|
I've used this no macOS for the last few days and think this is ready to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires pyls 0.19 or later: palantir/python-language-server#344
With this PR
ide-pythonwill start the language server usingpython -m pyls. This means user can havepylsinstalled for two different versions of Python and are able to switch between them by modifying the "Python Executable" setting.This will also fix the issues where the
pylsexecutable is not installed in the correct PATH on some Linux setups which should help inexperienced users a lot.Closes #110
Closes #107
Closes #102
Closes #65
Closes #39
I would appreciate if somebody could test these changes so we can be confident it won't break 😉