Skip to content

Fix rxjs error #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Fix rxjs error #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da631e3
fix: use rxjs-compat instead of rxjs
aminya Nov 11, 2020
0e87456
chore: add built files
aminya Nov 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions dist/debugger/RemoteDebuggerCommandService.js
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions dist/debugger/utils.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions lib/debugger/RemoteDebuggerCommandService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import type {ConnectableObservable} from 'rxjs';
import type {ConnectableObservable} from 'rxjs-compat/bundles/rxjs-compat.umd.min.js';

import http from 'http';
import net from 'net';
import {Observable, Subject} from 'rxjs';
import {Observable, Subject} from 'rxjs-compat/bundles/rxjs-compat.umd.min.js';
import {getLogger} from 'log4js';
import {sleep} from '@atom-ide-community/nuclide-commons/promise';

Expand Down
2 changes: 1 addition & 1 deletion lib/debugger/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {observeAddedHostnames} from '@atom-ide-community/nuclide-commons-atom/pr
import nuclideUri from '@atom-ide-community/nuclide-commons/nuclideUri';
import {fastDebounce} from '@atom-ide-community/nuclide-commons/observable';
import UniversalDisposable from '@atom-ide-community/nuclide-commons/UniversalDisposable';
import {Observable} from 'rxjs';
import {Observable} from 'rxjs-compat/bundles/rxjs-compat.umd.min.js';
import {track} from '@atom-ide-community/nuclide-commons/analytics';
import * as RemoteDebuggerCommandServiceLocal from './RemoteDebuggerCommandService';
import nullthrows from 'nullthrows';
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
"react": "16.6.3",
"reflect-metadata": "0.1.12",
"rxjs": "5.5.9",
"rxjs-compat": "6.3.3",
"semver": "5.5.0",
"tmp": "0.0.29",
"tree-kill": "1.1.0",
Expand Down