Fix "Unable to start pyls" for Debian #32
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgeiger
requested changes
Oct 20, 2017
lib/main.js
Outdated
| // For some reason Atom only detects the correct env if started from the command line on Mac. | ||
| const env = process.platform === "darwin" ? await shellEnv() : process.env; | ||
| // For some reason Atom only detects the correct env if started from the command line on Mac and Debian. | ||
| const env = process.platform === "darwin" || process.platform === "darwin" ? await shellEnv() : process.env; |
There was a problem hiding this comment.
This doesn't change behavior.
There was a problem hiding this comment.
Ough, my bad! It was supposed to be linux not darwin in the second condition. I fixed it in the PR.
Anyways, it would be interesting to know if this is a personal issue or general to Linux/Debian systems.
There was a problem hiding this comment.
Unfortunately this will re-introduce #20 😕
|
Maybe there's some combination of these checks and using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes my issue #31 on my Debian machine.
Definitely needs further review as it affects all linux machines!
As with the already implemented workaround for Mac, this is not more than a workaround and might not get down to the root of the problem.