Skip to content

Conversation

rob-a-bolton
Copy link
Contributor

@rob-a-bolton rob-a-bolton commented Nov 6, 2017

Made extension virtualenv aware by exporting VIRTUAL_ENV when bin/python detected from project root, fixing #37

Copy link
Collaborator

@lgeiger lgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🎉

I'm not using virtual envs on my local PC, so I'm not able to test this workflow but this looks like the right thing to do.

@lgeiger lgeiger merged commit eb62c6a into atom-community:master Nov 9, 2017
@lgeiger
Copy link
Collaborator

lgeiger commented Nov 9, 2017

@rob-a-bolton Would you be interested in helping us maintain ide-python? I'd be very happy to add you as a collaborator to the repo.

@rob-a-bolton
Copy link
Contributor Author

No problem, thanks for the package - it's very useful. I'd certainly be up for helping to maintain ide-python.

@lgeiger
Copy link
Collaborator

lgeiger commented Nov 11, 2017

Cool, I'll add you to the repo 🎉

@FranklinYu
Copy link

FranklinYu commented Dec 8, 2017

Doesn't seem to work on Windows? I'm using venv from Python 3.

Never mind, I was drunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants