This repository was archived by the owner on Dec 15, 2022. It is now read-only.
List Atom version in apm --version
#453
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jebschiefer
changed the title
apm --versionapm --version
|
A great starting point! It fails the build and you added no test for the new functionality. When I run the tests locally on OS X with your change they fail for the same reason as the build. I'm not quite sure why, did you manage to get them running locally @jebschiefer? |
|
@evjan Thanks for checking this out. Looks like I was using a different version of node than Travis CI. I will look into this more this evening or tomorrow. It may have to do with the path returned by |
|
No activity on this PR which would require merge conflict resolution and specs. |
virtuoushub
pushed a commit
to virtuoushub/apm
that referenced
this pull request
Sep 29, 2017
virtuoushub
pushed a commit
to virtuoushub/apm
that referenced
this pull request
Sep 29, 2017
virtuoushub
pushed a commit
to virtuoushub/apm
that referenced
this pull request
Sep 29, 2017
virtuoushub
pushed a commit
to virtuoushub/apm
that referenced
this pull request
Oct 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #382
Please let me know if there is a better approach to this (like using
spawningetPythonVersionor something else).