This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix broken arpeggios with meta/ctrl keys #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunsfeld
approved these changes
Dec 3, 2018
|
Published in v8.2.12. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
We noticed that keybindings that partially matched arpeggios behaved pretty strangely. For example:
⌘K(which is a partial match for the "Pane: Split" commands)⌘KpartialMatchTimeout⌘Kagain)If you've given up after step 3, 4 could happen a while later, after you've moved on. What's it doing? Some thing you forgot about 😄
This changes fixes the problem by scheduling the timeout not when an exact match was dispatched (which shouldn't be possible AFAIK), but when an exact match was found. I added a test to identify the case, which fails before the commit and passes after.