Fix scripts on Windows #1054
Fix scripts on Windows #1054
Conversation
This reverts commit 8742f6c. The `node_modules/.bin/apm` is a bash script not a js script, so on Windows `node node_modules/.bin/apm` would fail with: ``` C:\cygwin\home\zcbenz\codes\atom\node_modules\.bin\apm:2 basedir=`dirname "$0"` ^ SyntaxError: Unexpected token ILLEGAL at Module._compile (module.js:439:25) at Object.Module._extensions..js (module.js:474:10) at Module.load (module.js:356:32) at Function.Module._load (module.js:312:12) at Function.Module.runMain (module.js:497:10) at startup (node.js:119:16) at node.js:901:3 ```
| @@ -24,7 +24,7 @@ var commands = [ | |||
| joinCommands('cd vendor/apm', 'npm install --silent .'), | |||
| 'npm install --silent vendor/apm', | |||
| echoNewLine, | |||
| 'node node_modules/.bin/apm install --silent' | |||
| 'node vendor/apm/bin/apm install --silent', | |||
There was a problem hiding this comment.
We really need to run it from node_modules since that is the JS version, running it out vendor runs the Coffee version.
Could this just be node_modules/atom-package-manager/bin/apm instead to work on windows?
There was a problem hiding this comment.
Yeah node_modules/atom-package-manager/bin/apm seems a better choice to me.
There was a problem hiding this comment.
Cool, so just to confirm, we should never use paths to things in node_modules/.bin since on windows they won't exist?
There was a problem hiding this comment.
Usually node_modules/.bin/xxx would be a bash script for POSIX systems, and node_modules/.bin/xxx.cmd would be a batch file for Windows, we could use things under node_modules/.bin but the code would be platform-dependent.
| spawn {cmd: 'unzip', args: [zipPath, '-d', directoryPath]}, (error) -> | ||
| rm(zipPath) | ||
| callback(error) | ||
| else |
There was a problem hiding this comment.
Does the unzip command on windows not work?
There was a problem hiding this comment.
No, there is no unzip command on Windows unless you installed a third party tool.
This fixed some errors when running
grunt,build,testandbootstrapon Windows.