This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Allow scope mappings to be refined via match rules #17738
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the TextMate grammars, some tokens are highlighted differently based on their content. For example,
document
andexports
and other common identifiers are colored differently than normal variables (even though they are technically normal variables).Tree Sitter's highlighting system didn't support this... until now.
This PR adds tooling to TreeSitterLanguageMode enabling match rules on the RHS of a scope mapping in the atom grammar definition:
Example:
The first rule that matches is applied, so SOME_CONSTANT will resolve to the scope
constant
even though it also matches/^[A-Z]/
. String rules (such asvariable
above) always match, applying the specified scope (a nicety for default cases).