-
Notifications
You must be signed in to change notification settings - Fork 17.4k
Default to @atom/notify for file system notifications #19244
Commits on May 2, 2019
-
Default to @atom/notify for file system notifications
There's still some work to do to make this work on Linux and support switching between notification back-ends.
Nathan Sobo committedMay 2, 2019 Configuration menu - View commit details
-
Copy full SHA for 89a7aa8 - Browse repository at this point
Copy the full SHA 89a7aa8View commit details -
Nathan Sobo committed
May 2, 2019 Configuration menu - View commit details
-
Copy full SHA for b49e399 - Browse repository at this point
Copy the full SHA b49e399View commit details -
Nathan Sobo committed
May 2, 2019 Configuration menu - View commit details
-
Copy full SHA for 781cb90 - Browse repository at this point
Copy the full SHA 781cb90View commit details -
Nathan Sobo committed
May 2, 2019 Configuration menu - View commit details
-
Copy full SHA for 90ec3e0 - Browse repository at this point
Copy the full SHA 90ec3e0View commit details -
Remove top-level construction of a notify Watcher
It was actually dead code and is screwing up V8 startup snapshots.
Nathan Sobo committedMay 2, 2019 Configuration menu - View commit details
-
Copy full SHA for f9d9ed8 - Browse repository at this point
Copy the full SHA f9d9ed8View commit details -
Eliminate references to undefined watcher variable
Nathan Sobo committedMay 2, 2019 Configuration menu - View commit details
-
Copy full SHA for cf05317 - Browse repository at this point
Copy the full SHA cf05317View commit details -
Shim onDidError method on returned watcher
Need to figure out what to do with this for the long-term.
Nathan Sobo committedMay 2, 2019 Configuration menu - View commit details
-
Copy full SHA for b313b94 - Browse repository at this point
Copy the full SHA b313b94View commit details -
Remove logic supporting dynamic switching of path watcher backends
The logic is pretty complex and I don't want to take the time to integrate @atom/notify with it. I left a bunch of stuff commented out in this commit just in case these changes break the build. I'll do another pass to delete commented code once we go green.
Nathan Sobo committedMay 2, 2019 Configuration menu - View commit details
-
Copy full SHA for 508b56d - Browse repository at this point
Copy the full SHA 508b56dView commit details -
Nathan Sobo committed
May 2, 2019 Configuration menu - View commit details
-
Copy full SHA for 9b39eea - Browse repository at this point
Copy the full SHA 9b39eeaView commit details -
Nathan Sobo committed
May 2, 2019 Configuration menu - View commit details
-
Copy full SHA for 6ea9a15 - Browse repository at this point
Copy the full SHA 6ea9a15View commit details -
Use async/await in test to see if it fixes Windows failures on CI
Nathan Sobo committedMay 2, 2019 Configuration menu - View commit details
-
Copy full SHA for f8d7c9c - Browse repository at this point
Copy the full SHA f8d7c9cView commit details -
Prompt to restart Atom when the file system watcher setting changes
I experimented with just reloading the Window, but ran into problems. I'm also worried about a situation where there are multiple windows. Since this setting should be changed rarely, I think prompting for a restart is an expedient solution.
Nathan Sobo committedMay 2, 2019 Configuration menu - View commit details
-
Copy full SHA for da52d16 - Browse repository at this point
Copy the full SHA da52d16View commit details
Commits on May 3, 2019
-
Work around 8.3 path issue on Azure Windows
Nathan Sobo committedMay 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 1ec8e77 - Browse repository at this point
Copy the full SHA 1ec8e77View commit details -
Stop all watchers before attempting to replace directory with file
I think that the notify subprocess might be holding a lock on the watched directory on Windows.
Nathan Sobo committedMay 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 5bfbdd2 - Browse repository at this point
Copy the full SHA 5bfbdd2View commit details -
⬆️ @atom/notify@1.0.5 to explicitly unwatch on kill
Nathan Sobo committedMay 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 932aaac - Browse repository at this point
Copy the full SHA 932aaacView commit details
Commits on May 6, 2019
-
⬆️ @atom/notify@1.0.6 to kill notify subprocess on parent exit
Nathan Sobo committedMay 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 25083da - Browse repository at this point
Copy the full SHA 25083daView commit details -
⬆️ @atom/notify@1.1 for improved error handling
Nathan Sobo committedMay 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 1d1b450 - Browse repository at this point
Copy the full SHA 1d1b450View commit details
Commits on May 7, 2019
-
Throw exceptions when there are @atom/notify watcher errors
This will surface these errors to users and to our exception reporting infrastructure to ensure we get feedback on the new backend in the wild.
Nathan Sobo committedMay 7, 2019 Configuration menu - View commit details
-
Copy full SHA for f1bb55d - Browse repository at this point
Copy the full SHA f1bb55dView commit details -
Merge remote-tracking branch 'origin/master' into ns/notify
Nathan Sobo committedMay 7, 2019 Configuration menu - View commit details
-
Copy full SHA for db40641 - Browse repository at this point
Copy the full SHA db40641View commit details
Commits on May 8, 2019
-
Enable 'poll' option for @atom/notify-based fs watching
Nathan Sobo committedMay 8, 2019 Configuration menu - View commit details
-
Copy full SHA for bfdb1fa - Browse repository at this point
Copy the full SHA bfdb1faView commit details -
Default to 'native' watcher on the stable channel just to be safe
Nathan Sobo committedMay 8, 2019 Configuration menu - View commit details
-
Copy full SHA for 6da489e - Browse repository at this point
Copy the full SHA 6da489eView commit details -
Revert "Default to 'native' watcher on the stable channel just to be …
…safe" This reverts commit 6da489e. This commit was messing up the V8 startup snapshot.
Nathan Sobo committedMay 8, 2019 Configuration menu - View commit details
-
Copy full SHA for 5366614 - Browse repository at this point
Copy the full SHA 5366614View commit details
Commits on May 9, 2019
-
Nathan Sobo committed
May 9, 2019 Configuration menu - View commit details
-
Copy full SHA for 58dece3 - Browse repository at this point
Copy the full SHA 58dece3View commit details -
Add clarifying assertion to test script
Nathan Sobo committedMay 9, 2019 Configuration menu - View commit details
-
Copy full SHA for e58d52e - Browse repository at this point
Copy the full SHA e58d52eView commit details
Commits on May 10, 2019
-
⬆️ @atom/notify@1.2.1 for better path handling on Windows
Nathan Sobo committedMay 10, 2019 Configuration menu - View commit details
-
Copy full SHA for 07c08d7 - Browse repository at this point
Copy the full SHA 07c08d7View commit details -
Normalize %TEMP% to a long path on Windows CI
This avoids problems with assertions that involve paths inside the temp folder.
Nathan Sobo committedMay 10, 2019 Configuration menu - View commit details
-
Copy full SHA for b1b1b15 - Browse repository at this point
Copy the full SHA b1b1b15View commit details -
Nathan Sobo committed
May 10, 2019 Configuration menu - View commit details
-
Copy full SHA for 9a176f6 - Browse repository at this point
Copy the full SHA 9a176f6View commit details -
Normalize to realpath in waitForEvents helper
Nathan Sobo committedMay 10, 2019 Configuration menu - View commit details
-
Copy full SHA for be7d129 - Browse repository at this point
Copy the full SHA be7d129View commit details -
Merge remote-tracking branch 'origin/master' into ns/notify
Nathan Sobo committedMay 10, 2019 Configuration menu - View commit details
-
Copy full SHA for 1d2878f - Browse repository at this point
Copy the full SHA 1d2878fView commit details