Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Default to @atom/notify for file system notifications #19244

Merged
merged 29 commits into from
May 11, 2019
Merged

Commits on May 2, 2019

  1. Default to @atom/notify for file system notifications

    There's still some work to do to make this work on Linux and support 
    switching between notification back-ends.
    Nathan Sobo committed May 2, 2019
    Configuration menu
    Copy the full SHA
    89a7aa8 View commit details
    Browse the repository at this point in the history
  2. ⬆️ @atom/notify@1.0.1

    Nathan Sobo committed May 2, 2019
    Configuration menu
    Copy the full SHA
    b49e399 View commit details
    Browse the repository at this point in the history
  3. Fix lint error

    Nathan Sobo committed May 2, 2019
    Configuration menu
    Copy the full SHA
    781cb90 View commit details
    Browse the repository at this point in the history
  4. ⬆️ @atom/notify@1.0.2

    Nathan Sobo committed May 2, 2019
    Configuration menu
    Copy the full SHA
    90ec3e0 View commit details
    Browse the repository at this point in the history
  5. Remove top-level construction of a notify Watcher

    It was actually dead code and is screwing up V8 startup snapshots.
    Nathan Sobo committed May 2, 2019
    Configuration menu
    Copy the full SHA
    f9d9ed8 View commit details
    Browse the repository at this point in the history
  6. Eliminate references to undefined watcher variable

    Nathan Sobo committed May 2, 2019
    Configuration menu
    Copy the full SHA
    cf05317 View commit details
    Browse the repository at this point in the history
  7. Shim onDidError method on returned watcher

    Need to figure out what to do with this for the long-term.
    Nathan Sobo committed May 2, 2019
    Configuration menu
    Copy the full SHA
    b313b94 View commit details
    Browse the repository at this point in the history
  8. Remove logic supporting dynamic switching of path watcher backends

    The logic is pretty complex and I don't want to take the time to 
    integrate @atom/notify with it. I left a bunch of stuff commented out in 
    this commit just in case these changes break the build. I'll do another 
    pass to delete commented code once we go green.
    Nathan Sobo committed May 2, 2019
    Configuration menu
    Copy the full SHA
    508b56d View commit details
    Browse the repository at this point in the history
  9. Fix lint errors 🙈

    Nathan Sobo committed May 2, 2019
    Configuration menu
    Copy the full SHA
    9b39eea View commit details
    Browse the repository at this point in the history
  10. ⬆️ @atom/notify@1.0.3

    Nathan Sobo committed May 2, 2019
    Configuration menu
    Copy the full SHA
    6ea9a15 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f8d7c9c View commit details
    Browse the repository at this point in the history
  12. Prompt to restart Atom when the file system watcher setting changes

    I experimented with just reloading the Window, but ran into problems. 
    I'm also worried about a situation where there are multiple windows. 
    Since this setting should be changed rarely, I think prompting for a 
    restart is an expedient solution.
    Nathan Sobo committed May 2, 2019
    Configuration menu
    Copy the full SHA
    da52d16 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2019

  1. Work around 8.3 path issue on Azure Windows

    Nathan Sobo committed May 3, 2019
    Configuration menu
    Copy the full SHA
    1ec8e77 View commit details
    Browse the repository at this point in the history
  2. Stop all watchers before attempting to replace directory with file

    I think that the notify subprocess might be holding a lock on the 
    watched directory on Windows.
    Nathan Sobo committed May 3, 2019
    Configuration menu
    Copy the full SHA
    5bfbdd2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    932aaac View commit details
    Browse the repository at this point in the history

Commits on May 6, 2019

  1. Configuration menu
    Copy the full SHA
    25083da View commit details
    Browse the repository at this point in the history
  2. ⬆️ @atom/notify@1.1 for improved error handling

    Nathan Sobo committed May 6, 2019
    Configuration menu
    Copy the full SHA
    1d1b450 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2019

  1. Throw exceptions when there are @atom/notify watcher errors

    This will surface these errors to users and to our exception reporting 
    infrastructure to ensure we get feedback on the new backend in the wild.
    Nathan Sobo committed May 7, 2019
    Configuration menu
    Copy the full SHA
    f1bb55d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    db40641 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2019

  1. Configuration menu
    Copy the full SHA
    bfdb1fa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6da489e View commit details
    Browse the repository at this point in the history
  3. Revert "Default to 'native' watcher on the stable channel just to be …

    …safe"
    
    This reverts commit 6da489e.
    
    This commit was messing up the V8 startup snapshot.
    Nathan Sobo committed May 8, 2019
    Configuration menu
    Copy the full SHA
    5366614 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2019

  1. 🔥 unused methods

    Nathan Sobo committed May 9, 2019
    Configuration menu
    Copy the full SHA
    58dece3 View commit details
    Browse the repository at this point in the history
  2. Add clarifying assertion to test script

    Nathan Sobo committed May 9, 2019
    Configuration menu
    Copy the full SHA
    e58d52e View commit details
    Browse the repository at this point in the history

Commits on May 10, 2019

  1. Configuration menu
    Copy the full SHA
    07c08d7 View commit details
    Browse the repository at this point in the history
  2. Normalize %TEMP% to a long path on Windows CI

    This avoids problems with assertions that involve paths inside the temp 
    folder.
    Nathan Sobo committed May 10, 2019
    Configuration menu
    Copy the full SHA
    b1b1b15 View commit details
    Browse the repository at this point in the history
  3. Test everything on Windows

    Nathan Sobo committed May 10, 2019
    Configuration menu
    Copy the full SHA
    9a176f6 View commit details
    Browse the repository at this point in the history
  4. Normalize to realpath in waitForEvents helper

    Nathan Sobo committed May 10, 2019
    Configuration menu
    Copy the full SHA
    be7d129 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1d2878f View commit details
    Browse the repository at this point in the history