This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Optimizations (Parcel + CompositeDisposable + Disposable + Emitter) #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
force-pushed
the
optimizations
branch
3 times, most recently
from
6017b72
to
8d99ccf
Compare
Merged
|
@darangi @sadick254 Will you have time to take a look at these PRs? If not, since this package is an npm package, I can get access to the repository through the disputes procedure and continue maintaining it (similar to how we did for atom-languageclient). |
|
We plan on looking into the PR's we have here as well as on our other core packages. |
|
@sadick254 I am just asking this to speed up the process. If you can offload the maintenance of some of the projects to the community, you will have more time focusing on the Atom's core. It is a Win-Win action. As an example, since we have got |
Lazy loading this small file will not have any considerable performance benefits
traditional for is faster: https://jsbench.me/67kgn473ko/1
aminya
force-pushed
the
optimizations
branch
2 times, most recently
from
46267de
to
65f0e10
Compare
aminya
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This adds a couple of optimizations:
How to review
Verification
All the tests pass. The changes are considered minor. They do not change the functionality.