Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Use rest parameters #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use rest parameters #54

wants to merge 1 commit into from

Conversation

icecream17
Copy link

Requirements for Contributing a Performance Improvement

Description of the Change

Change class definition to use rest parameters

Quantitative Performance Benefits

In principle, rest parameters take about 8ms per 100000 calls, vs arguments taking about 36ms

image

I'm not sure if this compiles to a faster version though.

In atom, even though for...of is supported, it still expands the loop into some polyfill:

image

Possible Drawbacks

I'm not sure if the compiler/bundler will handle this better

Verification Process

No regression checking needed

Applicable Issues

Release Notes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant