This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Performance Improvement
Description of the Change
Change class definition to use rest parameters
Quantitative Performance Benefits
In principle, rest parameters take about 8ms per 100000 calls, vs arguments taking about 36ms
I'm not sure if this compiles to a faster version though.
In atom, even though for...of is supported, it still expands the loop into some polyfill:
Possible Drawbacks
I'm not sure if the compiler/bundler will handle this better
Verification Process
No regression checking needed
Applicable Issues
Release Notes