This repository has been archived by the owner. It is now read-only.

Report uncaught exceptions occurring on the Teletype package #38

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
2 participants
@as-cii
Member

as-cii commented Nov 22, 2017

This will allow us to get a sense of what and how many exceptions are thrown in the Teletype package even if it is not yet bundled in Atom Core.

To test this, I created a fake exception on the Teletype package and verified it was correctly reported to BugSnag. I think we should hotfix this to stable and beta so that we can start gathering information without having to wait for a full release cycle.

/cc: @atom/maintainers

@as-cii as-cii requested a review from jasonrudolph Nov 22, 2017

@jasonrudolph

I think we should hotfix this to stable and beta so that we can start gathering information without having to wait for a full release cycle.

Given that we're only a few weeks away from the next stable release, how would you feel about hotfixing only to beta? I feel like that offers a good balance of risk management (i.e., zero risk of breaking things in the stable release 😅) and expediency (i.e., we're only waiting just a little bit longer before this change comes to the stable release in early December).

@as-cii

This comment has been minimized.

Show comment
Hide comment
@as-cii

as-cii Nov 28, 2017

Member

Given that we're only a few weeks away from the next stable release, how would you feel about hotfixing only to beta? I feel like that offers a good balance of risk management (i.e., zero risk of breaking things in the stable release 😅) and expediency (i.e., we're only waiting just a little bit longer before this change comes to the stable release in early December).

Yeah that sounds good. 👍

Member

as-cii commented Nov 28, 2017

Given that we're only a few weeks away from the next stable release, how would you feel about hotfixing only to beta? I feel like that offers a good balance of risk management (i.e., zero risk of breaking things in the stable release 😅) and expediency (i.e., we're only waiting just a little bit longer before this change comes to the stable release in early December).

Yeah that sounds good. 👍

@as-cii as-cii merged commit 9f83edc into master Nov 28, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@as-cii as-cii deleted the report-teletype-errors branch Nov 28, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.