Skip to content
This repository was archived by the owner on Sep 28, 2018. It is now read-only.

Report uncaught exceptions occurring on the Teletype package #38

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

as-cii
Copy link
Contributor

@as-cii as-cii commented Nov 22, 2017

This will allow us to get a sense of what and how many exceptions are thrown in the Teletype package even if it is not yet bundled in Atom Core.

To test this, I created a fake exception on the Teletype package and verified it was correctly reported to BugSnag. I think we should hotfix this to stable and beta so that we can start gathering information without having to wait for a full release cycle.

/cc: @atom/maintainers

@as-cii as-cii requested a review from jasonrudolph November 22, 2017 08:34
Copy link
Contributor

@jasonrudolph jasonrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should hotfix this to stable and beta so that we can start gathering information without having to wait for a full release cycle.

Given that we're only a few weeks away from the next stable release, how would you feel about hotfixing only to beta? I feel like that offers a good balance of risk management (i.e., zero risk of breaking things in the stable release 😅) and expediency (i.e., we're only waiting just a little bit longer before this change comes to the stable release in early December).

@as-cii
Copy link
Contributor Author

as-cii commented Nov 28, 2017

Given that we're only a few weeks away from the next stable release, how would you feel about hotfixing only to beta? I feel like that offers a good balance of risk management (i.e., zero risk of breaking things in the stable release 😅) and expediency (i.e., we're only waiting just a little bit longer before this change comes to the stable release in early December).

Yeah that sounds good. 👍

@as-cii as-cii merged commit 9f83edc into master Nov 28, 2017
@as-cii as-cii deleted the report-teletype-errors branch November 28, 2017 10:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants