New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID-based email avatars #1483

Merged
merged 3 commits into from May 24, 2018

Conversation

Projects
None yet
3 participants
@lee-dohm
Member

lee-dohm commented May 24, 2018

Description of the Change

Render avatars for ID-based anonymous GitHub email addresses.

Alternate Designs

None considered.

Benefits

People using ID-based anonymous GitHub email addresses get their avatars rendered too 馃榾

Possible Drawbacks

Makes the code a little more complex.

Applicable Issues

Fixes #1341

lee-dohm added some commits May 24, 2018

@lee-dohm lee-dohm changed the title from Id based email avatars to ID-based email avatars May 24, 2018

@smashwilson

This comment has been minimized.

Member

smashwilson commented May 24, 2018

Oh, awesome! I was afraid we'd need to go to GraphQL somehow for this.

@smashwilson smashwilson merged commit 69c97d0 into master May 24, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the id-based-email-avatars branch May 24, 2018

@annthurium

This comment has been minimized.

Contributor

annthurium commented May 24, 2018

nice work @lee-dohm !

@lee-dohm

This comment has been minimized.

Member

lee-dohm commented May 24, 2018

Thanks! 馃檱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment