Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

ID-based email avatars #1483

Merged
merged 3 commits into from
May 24, 2018
Merged

ID-based email avatars #1483

merged 3 commits into from
May 24, 2018

Conversation

lee-dohm
Copy link
Contributor

Description of the Change

Render avatars for ID-based anonymous GitHub email addresses.

Alternate Designs

None considered.

Benefits

People using ID-based anonymous GitHub email addresses get their avatars rendered too 😀

Possible Drawbacks

Makes the code a little more complex.

Applicable Issues

Fixes #1341

@lee-dohm lee-dohm changed the title Id based email avatars ID-based email avatars May 24, 2018
@smashwilson
Copy link
Contributor

Oh, awesome! I was afraid we'd need to go to GraphQL somehow for this.

@smashwilson smashwilson merged commit 69c97d0 into master May 24, 2018
@smashwilson smashwilson deleted the id-based-email-avatars branch May 24, 2018 17:42
@annthurium
Copy link

nice work @lee-dohm !

@lee-dohm
Copy link
Contributor Author

Thanks! 🙇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants