New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity "large" file patches by diff byte size, not line count #1501

Merged
merged 8 commits into from Jun 1, 2018

Conversation

Projects
None yet
1 participant
@smashwilson
Member

smashwilson commented Jun 1, 2018

A diff that contains changes to a small number of very long lines still chokes up the works. Let's call a patch "large" if it exceeds a given byte count instead of line count.

Fixes #1425.

smashwilson added some commits Jun 1, 2018

@smashwilson smashwilson merged commit ae5dbf7 into master Jun 1, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/size-not-lines branch Jun 1, 2018

smashwilson added a commit that referenced this pull request Jun 1, 2018

Merge pull request #1501 from atom/aw/size-not-lines
Identity "large" file patches by diff byte size, not line count

smashwilson added a commit that referenced this pull request Jun 1, 2018

Merge pull request #1501 from atom/aw/size-not-lines
Identity "large" file patches by diff byte size, not line count

smashwilson added a commit that referenced this pull request Jun 1, 2018

Merge pull request #1501 from atom/aw/size-not-lines
Identity "large" file patches by diff byte size, not line count

smashwilson added a commit that referenced this pull request Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment