Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad jump to file in reviews controller #2334

Merged
merged 2 commits into from Nov 7, 2019

Conversation

@wadethestealth
Copy link
Contributor

wadethestealth commented Nov 7, 2019

@smashwilson @lkashef @darangi

Fixes #2330

This was possibly overlooked during project management #2308, but now jumping to files uses an absolute path rather than a relative. This may have worked before because github's active context (chosen by active pane) and atom were probably assuming the same directory.

  • update tests
@smashwilson smashwilson merged commit 2d0b976 into atom:master Nov 7, 2019
6 checks passed
6 checks passed
atom.github Build #20191107.13 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux) Linux succeeded
Details
atom.github (MacOS) MacOS succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows) Windows succeeded
Details
@wadethestealth wadethestealth deleted the wadethestealth:jump-to-file branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.