Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2251 #2347

Merged
merged 1 commit into from Nov 21, 2019
Merged

Fix #2251 #2347

merged 1 commit into from Nov 21, 2019

Conversation

@wadethestealth
Copy link
Contributor

wadethestealth commented Nov 21, 2019

Description of the Change

This allows for users using light ui themes and dark syntax themes to read commit details.
This allows for users using dark ui themes and light syntax themes to read commit details.

Most dark and dark or light and light theme settings were previously readable, but ui text looked like it was in a syntax background context.

This change uses only the ui style variables for the commit detail heading, which increases style cohesion and readability.

Screenshot/Gif

One Light UI + One Dark Syntax:

Untitled

One Dark UI + One Light Syntax

Untitled

Alternate Designs

Was thinking of using only syntax text variables, but the majority of variables already in use were ui. Also syntax text variables are coded by syntactic/semantic meaning and do not represent hierarchical meaning like ui variables do.

Benefits

  • Style cohesion
  • Readability

Possible Drawbacks

N/A

Applicable Issues

Fixes #2251

Tests

Manually done

Combinations tested:

  • Atom Dark UI
    • Atom Dark Syntax
    • Atom Light Syntax
    • Base 16 Tomorrow Dark Syntax
    • Base 16 Tomorrow Light Syntax
    • One Dark Syntax
    • One Light Syntax
    • Solarized Dark Syntax
    • Solarized Light Syntax
  • Atom Light UI
    • Atom Dark Syntax
    • Atom Light Syntax
    • Base 16 Tomorrow Dark Syntax
    • Base 16 Tomorrow Light Syntax
    • One Dark Syntax
    • One Light Syntax
    • Solarized Dark Syntax
    • Solarized Light Syntax
  • One Dark UI
    • Atom Dark Syntax
    • Atom Light Syntax
    • Base 16 Tomorrow Dark Syntax
    • Base 16 Tomorrow Light Syntax
    • One Dark Syntax
    • One Light Syntax
    • Solarized Dark Syntax
    • Solarized Light Syntax
  • One Light UI
    • Atom Dark Syntax
    • Atom Light Syntax
    • Base 16 Tomorrow Dark Syntax
    • Base 16 Tomorrow Light Syntax
    • One Dark Syntax
    • One Light Syntax
    • Solarized Dark Syntax
    • Solarized Light Syntax
@wadethestealth wadethestealth changed the title Fix heading color to reflect ui styles Fix #2251 Nov 21, 2019
@wadethestealth

This comment has been minimized.

Copy link
Contributor Author

wadethestealth commented Nov 21, 2019

@smashwilson all windows tests passed but returned a random bad code

@smashwilson

This comment has been minimized.

Copy link
Member

smashwilson commented Nov 21, 2019

Yeah, I've seen that one happen from time to time. Something is segfaulting... ?

In any case, I'm re-running it and I'll merge when green. Thanks!

@smashwilson smashwilson merged commit 1ec199a into atom:master Nov 21, 2019
6 checks passed
6 checks passed
atom.github #20191121.1 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux) Linux succeeded
Details
atom.github (MacOS) MacOS succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows) Windows succeeded
Details
@wadethestealth wadethestealth deleted the wadethestealth:fix-styles branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.