Fix #2251

[wadethestealth]

Description of the Change

This allows for users using light ui themes and dark syntax themes to read commit details.
This allows for users using dark ui themes and light syntax themes to read commit details.

Most dark and dark or light and light theme settings were previously readable, but ui text looked like it was in a syntax background context.

This change uses only the ui style variables for the commit detail heading, which increases style cohesion and readability.

Screenshot/Gif

One Light UI + One Dark Syntax:

One Dark UI + One Light Syntax

Alternate Designs

Was thinking of using only syntax text variables, but the majority of variables already in use were ui. Also syntax text variables are coded by syntactic/semantic meaning and do not represent hierarchical meaning like ui variables do.

Benefits

• Style cohesion
• Readability

Possible Drawbacks

N/A

Applicable Issues

Fixes #2251

Tests

Manually done

Combinations tested:

• Atom Dark UI
  • Atom Dark Syntax
  • Atom Light Syntax
  • Base 16 Tomorrow Dark Syntax
  • Base 16 Tomorrow Light Syntax
  • One Dark Syntax
  • One Light Syntax
  • Solarized Dark Syntax
  • Solarized Light Syntax
• Atom Light UI
  • Atom Dark Syntax
  • Atom Light Syntax
  • Base 16 Tomorrow Dark Syntax
  • Base 16 Tomorrow Light Syntax
  • One Dark Syntax
  • One Light Syntax
  • Solarized Dark Syntax
  • Solarized Light Syntax
• One Dark UI
  • Atom Dark Syntax
  • Atom Light Syntax
  • Base 16 Tomorrow Dark Syntax
  • Base 16 Tomorrow Light Syntax
  • One Dark Syntax
  • One Light Syntax
  • Solarized Dark Syntax
  • Solarized Light Syntax
• One Light UI
  • Atom Dark Syntax
  • Atom Light Syntax
  • Base 16 Tomorrow Dark Syntax
  • Base 16 Tomorrow Light Syntax
  • One Dark Syntax
  • One Light Syntax
  • Solarized Dark Syntax
  • Solarized Light Syntax

[wadethestealth]

@smashwilson all windows tests passed but returned a random bad code

[smashwilson]

Yeah, I've seen that one happen from time to time. Something is segfaulting... ?

In any case, I'm re-running it and I'll merge when green. Thanks!