This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix github failing tests for Atom's electron 9.4.1 upgrade #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2631 +/- ##
==========================================
- Coverage 93.46% 93.46% -0.01%
==========================================
Files 237 237
Lines 13215 13213 -2
Branches 1900 1900
==========================================
- Hits 12352 12349 -3
- Misses 863 864 +1
Continue to review full report at Codecov.
|
smashwilson
approved these changes
Feb 25, 2021
| `; | ||
|
|
||
| await new Promise(resolve => browserWindow.webContents.executeJavaScript(script, resolve)); | ||
| await browserWindow.webContents.executeJavaScript(script); |
There was a problem hiding this comment.
Ah, missed this one in the other pass, I see.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
Screenshot or Gif
N/A
Applicable Issues
atom/atom#21777 (comment)