-
Notifications
You must be signed in to change notification settings - Fork 48
Capture regexp begin/end as punctuation in Clojure syntax #66
Conversation
grammars/clojure.cson
Outdated
@@ -232,7 +232,13 @@ | |||
] | |||
'regexp': | |||
'begin': '#\\"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎨 Quotes don't need to be escaped.
Looks like specs need to be updated. |
I’ve updated specs |
Can you cut a release please? |
Is there a specific reason you'd like a new release? I'm only planning to publish a new release after Atom 1.17.0 is released since this is a bundled package. |
The only reason is I want to use the stuff :) But it’s not showstopper, so please follow whatever release process you’re comfortable with. When is Atom 1.17.0 due? |
I can't give an exact date, but probably sometime this month. If you really want to use it right now, you can install the package as a git package (pasting |
Thanks!
…On Wed, May 3, 2017 at 12:21 AM Wliu ***@***.***> wrote:
I can't give an exact date, but *probably* sometime this month. If you
really want to use it right now, you can install the package as a git
package (pasting https://github.com/atom/language-clojure into the
Install dialog in Settings View should work).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#66 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARabEOdXGTvyb-2R5HAEKOgwNV0dnAAks5r155LgaJpZM4NLNPr>
.
|
Capture regexp begin/end as punctuation in Clojure syntax
Capture regexp begin/end as punctuation in Clojure syntax
Description of the Change
When highlighting regexp, starting
#"
and ending"
should be of classpunctuation
. That is done e.g. for strings but was forgotten for regexpesAlternate Designs
This is a very simple change. I believe there’s only one way to do it.
Benefits
Regexpes are highlighted the same way everything else is (e.g. strings, vectors, maps).
Possible Drawbacks
None
Applicable Issues
None