Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Capture regexp begin/end as punctuation in Clojure syntax #66

Merged
merged 2 commits into from
Apr 28, 2017
Merged

Capture regexp begin/end as punctuation in Clojure syntax #66

merged 2 commits into from
Apr 28, 2017

Conversation

tonsky
Copy link
Contributor

@tonsky tonsky commented Apr 28, 2017

Description of the Change

When highlighting regexp, starting #" and ending " should be of class punctuation. That is done e.g. for strings but was forgotten for regexpes

Alternate Designs

This is a very simple change. I believe there’s only one way to do it.

Benefits

Regexpes are highlighted the same way everything else is (e.g. strings, vectors, maps).

Possible Drawbacks

None

Applicable Issues

None

@@ -232,7 +232,13 @@
]
'regexp':
'begin': '#\\"'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 Quotes don't need to be escaped.

@winstliu
Copy link
Contributor

Looks like specs need to be updated.

@tonsky
Copy link
Contributor Author

tonsky commented Apr 28, 2017

I’ve updated specs

@winstliu winstliu merged commit 82ff056 into atom:master Apr 28, 2017
@tonsky
Copy link
Contributor Author

tonsky commented May 2, 2017

Can you cut a release please?

@winstliu
Copy link
Contributor

winstliu commented May 2, 2017

Is there a specific reason you'd like a new release? I'm only planning to publish a new release after Atom 1.17.0 is released since this is a bundled package.

@tonsky
Copy link
Contributor Author

tonsky commented May 2, 2017

The only reason is I want to use the stuff :) But it’s not showstopper, so please follow whatever release process you’re comfortable with. When is Atom 1.17.0 due?

@winstliu
Copy link
Contributor

winstliu commented May 2, 2017

I can't give an exact date, but probably sometime this month. If you really want to use it right now, you can install the package as a git package (pasting https://github.com/atom/language-clojure into the Install dialog in Settings View should work).

@tonsky
Copy link
Contributor Author

tonsky commented May 3, 2017 via email

Slowki pushed a commit to Slowki/hy.tmLanguage that referenced this pull request Sep 14, 2018
Capture regexp begin/end as punctuation in Clojure syntax
Slowki pushed a commit to Slowki/hy.tmLanguage that referenced this pull request Sep 14, 2018
Capture regexp begin/end as punctuation in Clojure syntax
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants