New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper boundary-checking for and=, or= #157

Merged
merged 1 commit into from Oct 16, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Oct 16, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

and= and or= were being lumped with the other compound assignment operators, which since they're symbols do not require any whitespace around the operator. and= and or= however do require whitespace since they're English. Therefore, extract those two into their own pattern with proper boundary checking (identifier + spaces, or no identifier before the operator).

Alternate Designs

None.

Benefits

operand=, editor= will be tokenized correctly.

Possible Drawbacks

None.

Applicable Issues

Fixes #152

@50Wliu 50Wliu merged commit 428f4e1 into master Oct 16, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-boundary-checking branch Oct 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment