This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add proper boundary-checking for and=, or= #157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
and=
andor=
were being lumped with the other compound assignment operators, which since they're symbols do not require any whitespace around the operator.and=
andor=
however do require whitespace since they're English. Therefore, extract those two into their own pattern with proper boundary checking (identifier + spaces, or no identifier before the operator).Alternate Designs
None.
Benefits
operand=
,editor=
will be tokenized correctly.Possible Drawbacks
None.
Applicable Issues
Fixes #152