Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

winstliu
Copy link
Contributor

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

and= and or= were being lumped with the other compound assignment operators, which since they're symbols do not require any whitespace around the operator. and= and or= however do require whitespace since they're English. Therefore, extract those two into their own pattern with proper boundary checking (identifier + spaces, or no identifier before the operator).

Alternate Designs

None.

Benefits

operand=, editor= will be tokenized correctly.

Possible Drawbacks

None.

Applicable Issues

Fixes #152

@winstliu winstliu merged commit 428f4e1 into master Oct 16, 2017
@winstliu winstliu deleted the wl-boundary-checking branch October 16, 2017 22:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

or= does not have proper boundary checking
1 participant