This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Colorize rest parameters like other formal parameters #654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Currently, the tree-sitter grammar does not colorize rest parameters in functions. This is in contrast to the first-mate grammar, which does colorize such parameters. This PR colorizes rest parameters as
formal-parameter.identifier
, like other function parameters.Before:

After (with these PR changes):

Current first-mate grammar:

Alternate Designs
The selector was chosen because it is similar to the existing selector for formal parameters, so it should have no conflicts with other grammar rules.
Benefits
Rest parameters are now treated just like other formal function parameters.
Possible Drawbacks
None that I can see, since the grammar rule's selector is limited in scope.
Applicable Issues
N/A