New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update specs for first-mate changes #91

Merged
merged 1 commit into from Oct 30, 2017

Conversation

Projects
None yet
2 participants
@50Wliu
Member

50Wliu commented Oct 30, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Newlines are no longer guaranteed to exist on first-mate@7.0.9+. Don't try to match them and don't test for them in specs.

/cc @Fank

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Oct 30, 2017

Member

💚

Member

50Wliu commented Oct 30, 2017

💚

@50Wliu 50Wliu merged commit f2c7b38 into master Oct 30, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-first-mate-changes branch Oct 30, 2017

@Alhadis

This comment has been minimized.

Show comment
Hide comment
@Alhadis

Alhadis Oct 30, 2017

Contributor

And uh...I missed one by accident. Forgot to re-test specs locally before pushing

Isn't there an emoji that says that too?

Contributor

Alhadis commented Oct 30, 2017

And uh...I missed one by accident. Forgot to re-test specs locally before pushing

Isn't there an emoji that says that too?

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Oct 30, 2017

Member

I was actually on the Trusty branch which didn't have these changes :P. Mixed things up, promptly realized, and deleted my comment.

Member

50Wliu commented Oct 30, 2017

I was actually on the Trusty branch which didn't have these changes :P. Mixed things up, promptly realized, and deleted my comment.

@Alhadis

This comment has been minimized.

Show comment
Hide comment
@Alhadis

Alhadis Oct 30, 2017

Contributor

Maybe we need a broken 💚 emoji for these situations. 😄

Contributor

Alhadis commented Oct 30, 2017

Maybe we need a broken 💚 emoji for these situations. 😄

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Oct 30, 2017

Member

💔 :(

Member

50Wliu commented Oct 30, 2017

💔 :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment