This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Update specs for first-mate changes #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 |
Isn't there an emoji that says that too? |
|
I was actually on the Trusty branch which didn't have these changes :P. Mixed things up, promptly realized, and deleted my comment. |
|
Maybe we need a broken 💚 emoji for these situations. 😄 |
|
💔 :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Newlines are no longer guaranteed to exist on first-mate@7.0.9+. Don't try to match them and don't test for them in specs.
/cc @fank