New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add image_tag to viewhelpers #62

Merged
merged 1 commit into from Oct 25, 2017

Conversation

Projects
None yet
2 participants
@tshedor
Contributor

tshedor commented Oct 25, 2017

Description of the Change

image_tag is highlighted as a View Helper. It's an OG Rails helper. This was first reported on slim-template/language-slim#18.

Alternate Designs

The helper could remain unhighlighted.

Benefits

image_tag will be signaled in the editor as a built-in Rails helper and not a custom helper added to the app.

Possible Drawbacks

If a Ruby app has its own image_tag, is not a Rails app, and the editor has the Atom Ruby on Rails syntax highlighter, image_tag will be highlighted as though it's part of a Rails app, even though it is not.

Applicable Issues

slim-template/language-slim#18

@50Wliu 50Wliu merged commit d37a60a into atom:master Oct 25, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment