This repository was archived by the owner on Dec 15, 2022. It is now read-only.
add image_tag to viewhelpers #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
image_tagis highlighted as a View Helper. It's an OG Rails helper. This was first reported on slim-template/language-slim#18.Alternate Designs
The helper could remain unhighlighted.
Benefits
image_tagwill be signaled in the editor as a built-in Rails helper and not a custom helper added to the app.Possible Drawbacks
If a Ruby app has its own
image_tag, is not a Rails app, and the editor has the Atom Ruby on Rails syntax highlighter,image_tagwill be highlighted as though it's part of a Rails app, even though it is not.Applicable Issues
slim-template/language-slim#18