Syntax highlight breaks when Bash heredocument delimiter is indented

[aeschli]

From @benqzq on December 29, 2017 23:17

Syntax highlight breaks when Bash heredocument delimiter is indented:

Indented

Not indented

Why this phenomenon shouldn't happen

Bash functions (and even external heredocuments) tgnore/trim out, all indentations.

Hence, indenting a delimiter shouldn't effect syntax highlight, IMHO.

Copied from original issue: microsoft/vscode#40956

[aeschli]

@benqzq Can you attach a (complete) sample that shows the problem?

[aeschli]

From @benqzq on January 11, 2018 10:53

https://github.com/benqzq/system/blob/master/wsla.sh

[winstliu]

According to https://tldp.org/LDP/abs/html/here-docs.html, the delimiter must start at the first character of a line, except when the heredoc uses <<-.

As that's the case here I'll label this as a bug.

[winstliu]

The provided file does not reproduce the bug. Marking as more-information-needed.

[aeschli]

@benqzq The provided file does not reproduce the bug. Indenting AWSM also doesn't make a difference.

[chujungeng]

I have a similar problem. Syntax highlighting is totally broken by heredoc, which in my case is an awk script. Here's the link to my file: gradersLittleHelper/checkStat.sh

[winstliu]

@chujungeng your file looks fine to me, which means you should ask github/linguist to update the language-shellscript grammar.

[winstliu]

Thank you for your issue!

We haven't gotten a response to our questions in our comment #100 (comment). With only the information that is currently in the issue, we don't have enough information to take action. I'm going to close this but don't hesitate to reach out if you have or find the answers we need, we'll be happy to reopen the issue.

[chujungeng]

Have you actually opened my file inside Atom? The syntax highlighting is completely broken just like how it looks on GitHub. By contrast, it's compatible with Vim's syntax highlighting.